Open
Conversation
ecarreras
reviewed
Feb 20, 2026
| try: | ||
| recs = doc.findall("//*[@id='{}']".format(record_id)) | ||
| except Exception as e: | ||
| logger.error('{}: Failing find record id {}'.format(module_name, record_id)) |
Member
There was a problem hiding this comment.
aquest no fallarà mai, perquè simplement recs serà [] a l'altre sí perquè intentem accedir a la posició [0], potser aquí seria comprovar que recs no sigui buit.
Member
Author
There was a problem hiding this comment.
@ecarreras Millor que peti i et salti el LOG perquè sino ens pensem que actualitzem algun id i llavors no hi és. L'altres l'he posat sense mirar així que si podem fer-ho saltar si no troba cap registre enlloc del try 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds error handling to the
load_data_recordsfunction inoopgrade/oopgrade.pyto improve debugging and stability when loading records from XML. Now, if a record cannot be found, an error is logged and the exception is raised, making it easier to identify and troubleshoot issues during data import.Error handling improvements: