Open
Conversation
* Fix Spring 7 and Spring Boot 4 modules * Attempt to fix kotlin 2.2 issue * Second attempt to fix Kotlin 2.2 (#4610) * Second attempt to fix Kotlin 2.2 * Format code * Third attempt at fixing Kotlin 2.2 compat (#4613) --------- Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io> * Address compose-related issues * Fix tests for Spring 7 and Spring Boot 4 (#4614) * Second attempt to fix Kotlin 2.2 * Format code * Third attempt at fixing Kotlin 2.2 compat * Fix tests for Spring 7 and Spring Boot 4 * Move Spring 7 and Spring Boot 4 packages (#4615) * Move Spring 7 and Spring Boot 4 packages * Fix class not found due to OTel not supporting spring boot 4 yet (#4616) * Format code * some fixes * change kotlin 1.8 to 1.9 and some cleanup * ignore warnings about api level that is not relevant * fix optional dependencies in SentryAutoConfiguration * Update trace origin * Remove duplicate e2e test config * Update Strings for Spring 7 and Spring Boot 4 * Disable Spring Boot 4 agentless e2e tests for now --------- Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io> --------- Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io> Co-authored-by: markushi <markus.hintersteiner@sentry.io>
adinauer
requested review from
markushi,
romtsn and
stefanosiano
as code owners
adinauer
changed the base branch from
fix/spring-boot-3-4-request-caching
to
08-04-add_new_modules_for_spring_7_and_spring_boot_4
lcian
approved these changes
Aug 25, 2025
Comment on lines
+37
to
+38
| private @Nullable Long shutdownTimeout; | ||
| private @Nullable Long sessionFlushTimeout; |
Member
There was a problem hiding this comment.
m should we name these with the Millis suffix to match the naming in SentryOptions?
Member
Author
There was a problem hiding this comment.
I copied what we did for shutdownTimeout. Also open to adding the suffix.
Member
There was a problem hiding this comment.
I would prefer if we add the suffix for consistency, even though it's not too important
Base automatically changed from
08-04-add_new_modules_for_spring_7_and_spring_boot_4
to
main
August 26, 2025 10:34
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 23d6b12 | 354.10 ms | 408.38 ms | 54.28 ms |
| 96449e8 | 361.30 ms | 423.39 ms | 62.09 ms |
| 9fbb112 | 404.51 ms | 475.65 ms | 71.14 ms |
| ee747ae | 396.82 ms | 441.67 ms | 44.86 ms |
| f634d01 | 375.06 ms | 420.04 ms | 44.98 ms |
| 14ff5ee | 419.75 ms | 495.73 ms | 75.98 ms |
| ee747ae | 400.46 ms | 423.61 ms | 23.15 ms |
| 806307f | 357.85 ms | 424.64 ms | 66.79 ms |
| b750b96 | 421.25 ms | 444.09 ms | 22.84 ms |
| c8125f3 | 383.82 ms | 441.66 ms | 57.84 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 23d6b12 | 1.58 MiB | 2.10 MiB | 532.31 KiB |
| 96449e8 | 1.58 MiB | 2.11 MiB | 539.35 KiB |
| 9fbb112 | 1.58 MiB | 2.11 MiB | 539.18 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| f634d01 | 1.58 MiB | 2.10 MiB | 533.40 KiB |
| 14ff5ee | 1.58 MiB | 2.10 MiB | 535.08 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| 806307f | 1.58 MiB | 2.10 MiB | 533.42 KiB |
| b750b96 | 1.58 MiB | 2.10 MiB | 533.20 KiB |
| c8125f3 | 1.58 MiB | 2.10 MiB | 532.32 KiB |
Comment on lines
+123
to
+128
| private val tracingEnabledRunner = | ||
| baseContextRunner | ||
| .withPropertyValues("sentry.dsn=http://key@localhost/proj", "sentry.traces-sample-rate=1.0") | ||
| .withUserConfiguration( | ||
| NoOpTransportConfiguration::class.java | ||
| ) // Use no-op transport to avoid network calls |
Contributor
There was a problem hiding this comment.
The tracingEnabledRunner field is greyed out in IntelliJ due to being unused.
I see that both the spring-boot and spring-boot-jakarta tests use their tracing runner. Would it make sense for the spring-boot-4 tests to be consistent with tests for the previous spring boot versions?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#skip-changelog
💡 Motivation and Context
Less waiting