Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a duplicate assertion to the testStart function in the test file, which appears to be a test pipeline change based on the title. The change does not add any functional value as it repeats an existing assertion.
Changes:
- Added a duplicate assertion line in the
testStartfunction
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| rule := mRuleSet.rules[0].(*ruleWrapper) | ||
| require.Equal(t, rule.name, rsTag, "rule name mismatch") | ||
| require.Contains(t, mRuleSet.filter.Domain, domain, "rule not loaded") | ||
| require.Contains(t, mRuleSet.filter.Domain, domain, "rule not loaded") |
There was a problem hiding this comment.
This assertion is a duplicate of line 133 and provides no additional test coverage. The same condition is being checked twice with identical parameters and error message. Remove this duplicate line to improve test maintainability.
Suggested change
| require.Contains(t, mRuleSet.filter.Domain, domain, "rule not loaded") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.