Update S3 artifact metadata suffix , gardenlinux_epoch and `build_timestamp#314
Merged
NotTheEvilOne merged 4 commits intomainfrom Feb 10, 2026
Merged
Update S3 artifact metadata suffix , gardenlinux_epoch and `build_timestamp#314NotTheEvilOne merged 4 commits intomainfrom
suffix , gardenlinux_epoch and `build_timestamp#314NotTheEvilOne merged 4 commits intomainfrom
Conversation
This commit ensures `suffix` contains whatever is added to the base name. Signed-off-by: Tobias Wolf <wolf@b1-systems.de> On-behalf-of: SAP <tobias.wolf@sap.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #314 +/- ##
==========================================
+ Coverage 91.65% 91.69% +0.03%
==========================================
Files 42 42
Lines 2134 2132 -2
==========================================
- Hits 1956 1955 -1
+ Misses 178 177 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This commit ensures if a version is defined the major version number is used as `gardenlinux_epoch` Signed-off-by: Tobias Wolf <wolf@b1-systems.de> On-behalf-of: SAP <tobias.wolf@sap.com>
NotTheEvilOne
changed the title
suffix is not missing contentsuffix is not missing content and gardenlinux_epoch has the correct data type
Signed-off-by: Tobias Wolf <wolf@b1-systems.de> On-behalf-of: SAP <tobias.wolf@sap.com>
Gchbg
approved these changes
Feb 10, 2026
Signed-off-by: Tobias Wolf <wolf@b1-systems.de> On-behalf-of: SAP <tobias.wolf@sap.com>
NotTheEvilOne
changed the title
suffix is not missing content and gardenlinux_epoch has the correct data typesuffix , gardenlinux_epoch and `build_timestamp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR ensures
suffixcontains whatever is added to the base name, not just suffixes.gardenlinux_epochwas previously encoded as an integer. As maybe no version information is available the key will be added dynamically to S3 metadata based on availability.build_timestampwill be encoded as YAML type timestamp to ensure most compatibility between YAML parsers and libraries in different development environments reading YAML data and encoding it to programming specific representations / data types.Which issue(s) this PR fixes:
Fixes gardenlinux/gardenlinux#4294