Skip to content

Conversation

@marc1404
Copy link
Member

@marc1404 marc1404 commented Feb 9, 2026

How to categorize this PR?

/kind bug

What this PR does / why we need it:

Historically our source documentation files are using _index.md as the default name for index pages.
Since migrating from Hugo to VitePress, we're using a post-processing step (post-processing/part-index.js) to copy and rename all _index.md files to index.md.
This leads to duplicate search results since both _index.md and index.md are indexed by MiniSearch.

Example for the root cause of this issue in the local hugo folder created by Docforge:

image

Example test for filtered search results locally:

image

Which issue(s) this PR fixes:
Fixes #842

Special notes for your reviewer:

/cc @n-boshnakov @klocke-io

@marc1404 marc1404 requested a review from a team as a code owner February 9, 2026 13:16
@gardener-prow gardener-prow bot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. kind/bug Bug cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 9, 2026
@gardener-github-actions gardener-github-actions bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 9, 2026
@marc1404 marc1404 force-pushed the fix/842-filter-duplicate-saerch-results branch from 1af0c47 to 8ed8d76 Compare February 9, 2026 13:16
@gardener-prow gardener-prow bot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Feb 9, 2026
@github-actions github-actions bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. and removed ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Feb 9, 2026
@gardener-github-actions gardener-github-actions bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 9, 2026
@github-actions github-actions bot removed the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 9, 2026
@marc1404
Copy link
Member Author

marc1404 commented Feb 9, 2026

ℹ️ Fix for the failing PR preview workflow:

@marc1404
Copy link
Member Author

/ok-to-test

@gardener-prow gardener-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 10, 2026
@github-actions github-actions bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. and removed ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Feb 10, 2026
@github-actions
Copy link
Contributor

🚀 Preview Deployed

Your preview is being built and will be available at:
https://documentation-demo.gardener.cloud/pr-preview/pr-843/

Note: The preview will only be available after the GitHub Pages deployment completes in the demo repository.

To view the deployment status, visit: https://github.com/gardener/documentation-demo/actions

@marc1404
Copy link
Member Author

ping @n-boshnakov @klocke-io :)

@gardener-robot
Copy link

@klocke-io, @n-boshnakov You have pull request review open invite, please check

Copy link
Member

@klocke-io klocke-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2026
@gardener-prow
Copy link

gardener-prow bot commented Feb 12, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: klocke-io

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow
Copy link

gardener-prow bot commented Feb 12, 2026

LGTM label has been added.

DetailsGit tree hash: 291d3d07d71687228ca9536f875af053237f9153

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2026
@marc1404 marc1404 merged commit 2e0c4f2 into gardener:master Feb 12, 2026
10 of 11 checks passed
@marc1404 marc1404 deleted the fix/842-filter-duplicate-saerch-results branch February 12, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate search results

3 participants