Skip to content

SLO monitoring proposal #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
etiennnr wants to merge 9 commits into from
Closed

SLO monitoring proposal #818

etiennnr wants to merge 9 commits into from

Conversation

@etiennnr
Copy link
Member

@etiennnr etiennnr commented Jan 26, 2026

How to categorize this PR?

/kind discussion enhancement

What this PR does / why we need it:
Proposal for a Gardener SLO extension.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

@etiennnr
base proposal
d9ccd09 
Signed-off-by: Etienne Kemp-Rousseau <etienne.kr@hotmail.com>
@gardener-prow gardener-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/discussion Discussion (engaging others in deciding about multiple options) kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 26, 2026
@gardener-github-actions gardener-github-actions bot added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 26, 2026
@etiennnr
adding details
a4aa572 
Signed-off-by: Etienne Kemp-Rousseau <etienne.kr@hotmail.com>
@etiennnr etiennnr marked this pull request as ready for review January 26, 2026 22:30
@etiennnr etiennnr requested a review from a team as a code owner January 26, 2026 22:30
@gardener-prow gardener-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2026
marc1404
marc1404 reviewed Jan 27, 2026
View reviewed changes
Copy link
Member

@marc1404 marc1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry for your proposal to the index page as well:
https://github.com/etiennnr/documentation/blob/master/website/community/steering/product/_index.md

etiennnr and others added 2 commits January 27, 2026 09:41
@etiennnr
adding to index file as well
caf43d1 
Signed-off-by: Etienne Kemp-Rousseau <etienne.kr@hotmail.com>
@etiennnr @marc1404
Apply suggestions from code review
ad05550 
Co-authored-by: Marc Vornetran <marc1404@users.noreply.github.com>
marc1404
marc1404 reviewed Jan 27, 2026
View reviewed changes
Copy link
Member

@marc1404 marc1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for integrating my feedback!

/lgtm

/hold
until a date for the presentation has been fixed

@gardener-prow gardener-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jan 27, 2026
@gardener-prow
Copy link

gardener-prow bot commented Jan 27, 2026

LGTM label has been added.

DetailsGit tree hash: 8da387db1217940e45496ff8a50d16c26af20fa0

@etiennnr
Adding details and clarifications
fc15736 
Signed-off-by: Etienne Kemp-Rousseau <etienne.kr@hotmail.com>
@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2026
@etiennnr
error correction
70aea47 
Signed-off-by: Etienne Kemp-Rousseau <etienne.kr@hotmail.com>
@ScheererJ
Copy link
Member

ScheererJ commented Jan 27, 2026

Date proposal: Tue, 24.02., 3pm CET?

@etiennnr @rfranzke @vlerenc @timebertt

@ScheererJ
Copy link
Member

ScheererJ commented Jan 28, 2026

Scheduled technical steering meeting on Tuesday, 24.02.26, 3pm CET.

@etiennnr
adding presentation date
2049074 
Signed-off-by: Etienne Kemp-Rousseau <etienne.kr@hotmail.com>
marc1404
marc1404 reviewed Jan 28, 2026
View reviewed changes
Copy link
Member

@marc1404 marc1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unhold
/approve

@gardener-prow gardener-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 28, 2026
@etiennnr
date typo... sorry
50189ae 
Signed-off-by: Etienne Kemp-Rousseau <etienne.kr@hotmail.com>
chrkl
chrkl reviewed Feb 2, 2026
View reviewed changes
@etiennnr
Removing observability 2.0 references
d8f5e66 
Since this is mainly about OTEL support, which doesn't impact this proposal
@gardener-github-actions gardener-github-actions bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 2, 2026
@github-actions github-actions bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. and removed ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Feb 2, 2026
n-boshnakov
n-boshnakov approved these changes Feb 3, 2026
View reviewed changes
Copy link
Contributor

@n-boshnakov n-boshnakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow
Copy link

gardener-prow bot commented Feb 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marc1404, n-boshnakov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [marc1404,n-boshnakov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2026
@gardener-prow
Copy link

gardener-prow bot commented Feb 3, 2026

LGTM label has been added.

DetailsGit tree hash: 5c8ed924f9fdb0bedb7c96c791e74576b6dfc683

@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 12, 2026
@gardener-prow
Copy link

gardener-prow bot commented Feb 12, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@etiennnr etiennnr changed the title SLO extension proposal SLO monitoring proposal Feb 12, 2026
@gardener-github-actions gardener-github-actions bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 12, 2026
@github-actions github-actions bot removed the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 12, 2026
@etiennnr etiennnr mentioned this pull request Feb 12, 2026
Open
@etiennnr
Copy link
Member Author

etiennnr commented Feb 12, 2026

Closing in favor of gardener/enhancements#42

@etiennnr etiennnr closed this Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrkl chrkl chrkl left review comments

@marc1404 marc1404 marc1404 left review comments

@n-boshnakov n-boshnakov n-boshnakov approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/discussion Discussion (engaging others in deciding about multiple options) kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@etiennnr @ScheererJ @chrkl @marc1404 @n-boshnakov