fix/3682: text to icon list transformation

[Arukuen]

fixes #3682

Summary by CodeRabbit

• Bug Fixes
  • Refined icon list item block display behavior when no icon is selected.
  • Improved text content handling during block conversion operations for icon lists.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8875e9f and 22a9276.

📒 Files selected for processing (2)

• src/block/icon-list-item/edit.js
• src/block/icon-list/transforms.js

---

📝 Walkthrough

Walkthrough

These changes fix a bug where text disappears when converting Text Blocks to Icon List. The fixes add fallback logic to handle missing content fields and tighten the icon rendering condition to require a parent component.

Changes

Cohort / File(s)	Summary
Icon List Bug Fix src/block/icon-list-item/edit.js, src/block/icon-list/transforms.js	Modified default icon rendering condition to require parentUniqueId and added content/text fallback handling (content ?? text ?? '') in single and multi-block transform paths to prevent text loss during block conversion.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A hop, a skip, and text's restored,
Where icon lists once left things ignored,
With fallbacks neat and conditions tight,
The missing words now shine so bright! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title 'fix/3682: text to icon list transformation' directly references the issue number and clearly describes the main fix for text-to-icon-list transformation.
Linked Issues check	✅ Passed	Changes address issue #3682 by adding fallback text retrieval in transforms and guarding parentUniqueId in edit UI, ensuring text and icons display correctly after transformation.
Out of Scope Changes check	✅ Passed	All changes are directly related to fixing text-to-icon-list transformation in the two affected files (edit.js and transforms.js).
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/3682-text-to-icon-list

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🤖 Pull request artifacts

file	commit
pr3686-stackable-3686-merge.zip	22a9276

[github-actions]

Try this Pull Request in the WordPress playground: https://playground.wordpress.net/?mode=seamless#{"landingPage":"/wp-admin/post-new.php?post_type=page","preferredVersions":{"php":"latest","wp":"latest"},"steps":[{"step":"login","username":"admin","password":"password"},{"step":"installPlugin","pluginZipFile":{"resource":"url","url":"https://raw.githubusercontent.com/gambitph/Stackable/artifacts/pr3686-stackable-3686-merge.zip"}}]}