fix: exclude freemiums section to the global ul style for stackable

[Arukuen]

fixes #3681

Summary by CodeRabbit

• Style
  • Removed bullet points from lists in a specific section, providing a cleaner and more refined visual appearance throughout the interface.

[coderabbitai]

📝 Walkthrough

Walkthrough

A CSS rule was added to the welcome admin stylesheet to remove the default list-style-type from unordered lists within elements with the .fs-section class, addressing visual presentation of account settings elements.

Changes

Cohort / File(s)	Summary
List Styling Fix src/welcome/admin.scss	Added CSS rule setting list-style-type: none for unordered lists within .fs-section elements to remove default bullet styling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 With whiskers twitching, I hop with glee,
For overlapping labels now live carefree!
A dash of CSS, a list made clean,
The neatest account page I've ever seen! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the fix: excluding the freemiums section from global ul styles to prevent label overlap issues.
Linked Issues check	✅ Passed	The CSS change directly addresses issue #3681 by excluding .fs-section from global ul styling to prevent overlapping labels.
Out of Scope Changes check	✅ Passed	The changes are narrowly scoped to fixing the reported issue; only adds a CSS rule for .fs-section ul without introducing unrelated modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/3681-freemiums-overlapping-label

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🤖 Pull request artifacts

file	commit
pr3685-stackable-3685-merge.zip	5b35b53

[github-actions]

Try this Pull Request in the WordPress playground: https://playground.wordpress.net/?mode=seamless#{"landingPage":"/wp-admin/post-new.php?post_type=page","preferredVersions":{"php":"latest","wp":"latest"},"steps":[{"step":"login","username":"admin","password":"password"},{"step":"installPlugin","pluginZipFile":{"resource":"url","url":"https://raw.githubusercontent.com/gambitph/Stackable/artifacts/pr3685-stackable-3685-merge.zip"}}]}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/welcome/admin.scss`:
- Around line 442-444: The .fs-section ul rule currently only resets
list-style-type to none but leaves the enclosing ul's left padding (previously
set to 2em) intact, causing horizontal misalignment of Freemius action buttons;
update the .fs-section ul CSS rule to also reset the left padding (add
padding-left: 0) so the list is not indented and aligns correctly.

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

# First, examine the SCSS file to confirm the parent ul rule and the new fix
cat -n src/welcome/admin.scss | sed -n '430,450p'

Repository: gambitph/Stackable

Length of output: 526

---

🏁 Script executed:

# Search for the broader context around lines 442-444 to see the parent rule
cat -n src/welcome/admin.scss | sed -n '438,450p'

Repository: gambitph/Stackable

Length of output: 349

---

🏁 Script executed:

# Search for Freemius-related templates and action button rendering
rg -n "fs-section|fs-actions|Start Debug|Sync" --type=php -A 3 -B 3

Repository: gambitph/Stackable

Length of output: 26715

---

🏁 Script executed:

# Search for other CSS rules targeting fs-section or related selectors in the SCSS file
rg -n "\.fs-section|\.fs-actions" src/welcome/admin.scss -A 3 -B 1

Repository: gambitph/Stackable

Length of output: 131

---

🏁 Script executed:

# Search for the full context of the action buttons list in the account template
cat -n freemius/templates/account.php | sed -n '275,375p'

Repository: gambitph/Stackable

Length of output: 9521

---

🏁 Script executed:

# Check if there are any inline styles or other CSS affecting the Freemius button layout
rg -n "fs-section|fs-actions" --type=php -B 2 -A 5 | head -100

Repository: gambitph/Stackable

Length of output: 5369

---

🏁 Script executed:

# Check for any other CSS rules targeting fs-header-actions or that might affect the button layout
rg -n "fs-header-actions|fs_account" src/welcome/admin.scss -A 3 -B 1

Repository: gambitph/Stackable

Length of output: 44

---

🏁 Script executed:

# Search for any existing CSS that might reset padding on Freemius elements
rg -n "padding.*0|padding-left.*0" src/welcome/admin.scss

Repository: gambitph/Stackable

Length of output: 880

---

🏁 Script executed:

# Check line 878 context to see what padding-left: 0 rule applies to
sed -n '870,885p' src/welcome/admin.scss

Repository: gambitph/Stackable

Length of output: 307

---

🏁 Script executed:

# Search more broadly for Freemius or account-related styling in the entire SCSS file
rg -n "fs-header-actions|#fs_account|\.wrap\s*{" src/welcome/admin.scss -A 5 | head -50

Repository: gambitph/Stackable

Length of output: 205

---

🏁 Script executed:

# Search for fs-header-actions or account-related styling without problematic regex
rg -n "fs-header-actions|#fs_account" src/welcome/admin.scss -A 5

Repository: gambitph/Stackable

Length of output: 44

---

🏁 Script executed:

# Look at the broader context around the body.toplevel_page_stackable block to see all nested rules
sed -n '432,912p' src/welcome/admin.scss | grep -n "fs-\|padding-left\|list-style"

Repository: gambitph/Stackable

Length of output: 318

---

🏁 Script executed:

# Get the full context of the body.toplevel_page_stackable block to see all ul-related rules
sed -n '432,450p' src/welcome/admin.scss

Repository: gambitph/Stackable

Length of output: 374

---

Consider also resetting padding-left for .fs-section ul.

The enclosing block's ul rule (lines 438–441) applies both list-style-type: circle and padding-left: 2em. This fix only resets list-style-type: none, leaving the 2em left padding intact. Since the Freemius action buttons are rendered as a horizontal list within .fs-section, the residual indentation could contribute to misalignment.

Add padding-left: 0; to the .fs-section ul rule:

 	.fs-section ul {
 		list-style-type: none;
+		padding-left: 0;
 	}

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	.fs-section ul {
	list-style-type: none;
	}
	.fs-section ul {
	list-style-type: none;
	padding-left: 0;
	}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/welcome/admin.scss` around lines 442 - 444, The .fs-section ul rule
currently only resets list-style-type to none but leaves the enclosing ul's left
padding (previously set to 2em) intact, causing horizontal misalignment of
Freemius action buttons; update the .fs-section ul CSS rule to also reset the
left padding (add padding-left: 0) so the list is not indented and aligns
correctly.