Fix: Handle Undefined Axis Property Error#317
Closed
thierryc wants to merge 2 commits intofoliojs:masterfrom
anotherplanet-io:master
Closed
Fix: Handle Undefined Axis Property Error#317thierryc wants to merge 2 commits intofoliojs:masterfrom anotherplanet-io:master
thierryc wants to merge 2 commits intofoliojs:masterfrom
anotherplanet-io:master
Conversation
use instance.postscriptNameID as fallback name for namedVariations when the instance.name.en is not available
|
I don't think this is the right solution. This PR basically set the problemed instance name to the axisTag. This bug happens when the instance name happen to be the subFamilyName, not when it doesn't exist. It should retrieve the correct name from the name table, before fall back to axisTag as the last resort.
the name should be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the problem of undefined axis.name.en
Property by implementing axis tag trimming when the value is not readable.
Related to #297 #272
Font in error exemple :
https://github.com/clauseggers/Playfair/blob/master/fonts/VF-TTF/PlayfairItalicVF.ttf
output: