fix(HappyHare): Retains the correct font size for filament status messages #1788
+60
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
Moves the MMU “filament status message” from MmuCard’s HTML layout into the MmuFilamentStatus SVG so the text scales proportionally with the rest of the status display across different aspect ratios.
Changes:
- Adjusts the filament status SVG viewBox and adds an SVG
<text>node for the status message. - Relocates the
statusTextcomputed logic (andcapitalizehelper) fromMmuCardintoMmuFilamentStatus. - Removes the old status text container from
MmuCard’s template.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/components/widgets/mmu/MmuFilamentStatus.vue | Adds SVG-rendered status text and moves statusText computation into the filament status component. |
| src/components/widgets/mmu/MmuCard.vue | Removes the HTML-rendered status text so the SVG becomes the single source of truth for that message. |
Comment on lines
+214
to
+221
| <text | ||
| x="282" | ||
| y="18" | ||
| font-size="16px" | ||
| text-anchor="middle" | ||
| > | ||
| {{ statusText }} | ||
| </text> |
There was a problem hiding this comment.
The new status is outside the existing that sets font-family/font-size styling (e.g. font-family: Roboto). As a result it will render with the browser default font and likely look inconsistent vs the rest of the SVG text. Consider applying the same font styling (wrap in the same styled or set font-family/font-size consistently).
Suggested change
| <text | |
| x="282" | |
| y="18" | |
| font-size="16px" | |
| text-anchor="middle" | |
| > | |
| {{ statusText }} | |
| </text> | |
| <g style="font-family: Roboto, sans-serif;"> | |
| <text | |
| x="282" | |
| y="18" | |
| font-size="16px" | |
| text-anchor="middle" | |
| > | |
| {{ statusText }} | |
| </text> | |
| </g> |
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
pedrolamas
approved these changes
Feb 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the display of the "filament status message" which gives details of current movement from a vue text field and puts it in the filament status SVG. This ensures the font remains proportional to the rest of the status information. Previously on very narrow or wide displays, text would wrap or be of the incorrect size.
Related Tickets & Documents
n/a
Mobile & Desktop Screenshots/Recordings
Example mismatch prior:
Fixed as part of filament status component:
Signed-off-by: Paul Morgan moggieuk@hotmail.com