-
Notifications
You must be signed in to change notification settings - Fork 10
v0.0.4 #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
roncodes
wants to merge
12
commits into
main
Choose a base branch
from
dev-v0.0.4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
v0.0.4 #4
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d5d0118
feat: Add registry developer account registration command
79a2148
v0.0.4
roncodes e5fa44a
Merge pull request #2 from fleetbase/feature/registry-developer-accou…
roncodes e47167e
feat: Add install-fleetbase command (merged with register command)
5a608c5
Merge pull request #5 from fleetbase/feature/install-fleetbase-comman…
roncodes 7d9233f
fix: Restore executable permission on index.js
e63a888
feat: Auto-clone Fleetbase repository if not present
2a08b01
Merge pull request #6 from fleetbase/feature/install-fleetbase-comman…
roncodes 117da69
feat: Add --host parameter to register command
d7e9e88
fix: Support full URL with protocol in --host parameter
88f8564
fix: Handle both array and string error formats in register command
037434b
debug: Add detailed logging to register command
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
Copilot Autofix
AI about 11 hours ago
In general, to fix clear‑text logging of sensitive information, you should either (1) avoid logging the sensitive fields entirely, or (2) mask/redact them before logging. For passwords, the best practice is to never log them, even in masked form if avoidable.
Here, the minimal, behavior‑preserving fix is to keep the helpful logging of request parameters but omit or redact the
passwordfield when printing. We can do this by creating a shallow copy ofregistrationDataspecifically for logging, removing or masking thepasswordproperty, and then passing that safe object toJSON.stringify. This keeps the registration logic and API call unchanged; only the logging statement is updated.Concretely, in
index.jsaround line 790–792, we will replace:with code that constructs a
registrationDataForLogobject (using object spread) and setspasswordto a placeholder (or deletes it) before logging. No new imports are needed; we can use plain JavaScript. The rest of the file remains as is.