fix: limit concurrent funding tasks and handle "already known" gracefully #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ully fund_accounts() spawned all funding tasks concurrently with no limit, overwhelming the RPC with connections (201 simultaneous requests). Additionally, "already known" errors (from txs still in the mempool from a previous run) were treated as fatal. Now they log a warning and continue, since the tx is already pending and will be mined. Changes: - add semaphore (25 concurrent tasks) to fund_accounts - handle "already known" RPC error as a warning, not a fatal error - replace expect() with graceful handling on channel send
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fund_accounts()spawned all funding tasks concurrently with no limit, overwhelming the RPC with connections (e.g. 201 simultaneous requests with-a 125)Fixes:
FUNDING_CONCURRENCY_LIMIT = 25) to cap concurrent funding tasksexpect()with graceful handling on channel sendTest plan
cargo check -p contender_clicompiles cleanlycargo test -p contender_cli— 38 passed (1 pre-existing failure unrelated to this change)-a 125(201 accounts)