-
Notifications
You must be signed in to change notification settings - Fork 1
FCE-2767 fetch older events on room join #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements fetching historical events when joining a room, ensuring users can see past events before subscribing to new ones. The implementation addresses synchronization between past event retrieval and real-time subscription to prevent race conditions.
Changes:
- Added backend endpoint
getEventsto retrieve historical events and the last event ID for a given room - Updated frontend hook to fetch past events before subscribing, using the
lastEventIdto ensure continuity - Removed unused ElevenLabs integration files (session, audio interface, and API implementation)
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| deep-sea-stories/packages/web/src/hooks/useAgentEvents.ts | Refactored to fetch historical events before subscribing, added race condition handling with active flag |
| deep-sea-stories/packages/backend/src/router.ts | Exported and registered the new getEvents endpoint |
| deep-sea-stories/packages/backend/src/controllers/notifications.ts | Added getEvents procedure to retrieve event history and last event ID |
| deep-sea-stories/packages/backend/src/agent/elevenlabs/session.ts | Removed file containing ElevenLabs session implementation |
| deep-sea-stories/packages/backend/src/agent/elevenlabs/audioInterface.ts | Removed file containing ElevenLabs audio interface |
| deep-sea-stories/packages/backend/src/agent/elevenlabs/api.ts | Removed file containing ElevenLabs API client |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PiotrWodecki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.