FCE-2755 Agent vision #224
Open
+78
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
Updates SDK/server submodules and expands the Agents tutorial to document “agent vision” via explicit video-frame capture and delivery.
Changes:
- Bump multiple git submodules (web-client-sdk, python/js server SDKs, and server/proto components).
- Add a new “Making the Agent see” section to the Agents tutorial with TypeScript and Python examples for capturing images.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web-client-sdk | Submodule bump to pick up agent vision-related SDK changes. |
| packages/python-server-sdk | Submodule bump to pick up image capture / track image message support. |
| packages/js-server-sdk | Submodule bump to pick up image capture / track image event support. |
| docs/tutorials/agents.mdx | Adds documentation + examples for requesting and receiving video frames. |
| api/room-manager | Submodule bump for server-side support of new agent image capture flow. |
| api/protos | Submodule bump to include updated protobuf definitions for track image messages. |
| api/fishjam-server | Submodule bump for server changes supporting agent vision. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
| Unlike audio, which streams continuously, video frames must be explicitly requested and arrive asynchronously. | ||
|
|
||
| :::tip | ||
| We recommend not requesting frames more than once per second to avoid unnecessary load. |
Member
There was a problem hiding this comment.
suggestion: I would rephrase this and maybe make it a :::note or :::important that this is a rate limit, not a recommendation
|
|
||
| </Tabs> | ||
|
|
||
| ### Making the Agent see |
Member
There was a problem hiding this comment.
suggestion: We should mention that currently we send jpeg images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes in detail