Draft
Conversation
bd88bf8 to
9be4bc0
Compare
Contributor
PR #655: Add Zod and Drizzle ORM MigrationOverviewThis PR makes significant changes to the Fireproof codebase, transitioning from a custom SQL abstraction layer to using Drizzle ORM with LibSQL, and implementing Zod for schema validation. The PR is currently WIP (Work In Progress) and tests are failing. Key Changes1. Database Layer Migration
2. Zod Schema Validation
3. Configuration and Setup
4. Dependencies
Current IssuesThe tests are failing with a LibSQL error: This appears to be related to an incorrect database URL format in sql: drizzle(createClient({ url: `file://./dist/node-meta.sqlite` }))The error suggests the file URL format is incorrect and should either be:
Next Steps
ImpactThis migration brings several benefits:
|
9be4bc0 to
50f53af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
do not forget --- the way to better software.