feat(internal): IR-side support for automatic webhook signature verification#12567
Open
patrickthornton wants to merge 4 commits intomainfrom
Open
feat(internal): IR-side support for automatic webhook signature verification#12567patrickthornton wants to merge 4 commits intomainfrom
patrickthornton wants to merge 4 commits intomainfrom
Conversation
Contributor
🌱 Seed Test SelectorSelect languages to run seed tests for:
How to use: Click the ⋯ menu above → "Edit" → check the boxes you want → click "Update comment". Tests will run automatically and snapshots will be committed to this PR. |
Comment on lines
137
to
145
| signatureVerification: | ||
| signatureExtension != null | ||
| ? { | ||
| header: signatureExtension.header, | ||
| algorithm: signatureExtension.algorithm, | ||
| encoding: signatureExtension.encoding, | ||
| payloadFormat: signatureExtension["payload-format"] | ||
| } | ||
| : undefined, |
Contributor
There was a problem hiding this comment.
Missing default values for optional signature fields when converting from OpenAPI. This creates an inconsistency with the Fern definition converter which applies defaults (sha256, base64, body-only). When these fields are undefined from OpenAPI sources, downstream generators may fail or behave differently than when using Fern definitions.
signatureVerification:
signatureExtension != null
? {
header: signatureExtension.header,
algorithm: signatureExtension.algorithm ?? "sha256",
encoding: signatureExtension.encoding ?? "base64",
payloadFormat: signatureExtension["payload-format"] ?? "body-only"
}
: undefined,Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
24bcf35 to
486a207
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds IR support for automatic webhook signature verification through an optional parameter:
With the following schema:
Changes Made
To the OpenAPI-IR, the Fern Definition, and the IR.
Testing
Added to the IR test fixture
webhooksto test that this passes through correctly.