Conversation
|
Hi @yawn! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Let me know if I should followup with DRY-ing up the workflows and potentially Linux here as well or if this is entirely out of scope for PR's. |
Attempt to fix #3818 partially.
This is currently just a 1:1 copy of the windows release without any attempt to DRY up pinned
checkoutversion (or other dependencies).When triggered appropriately this will build
zstdusing the same structure as the windows equivalents. Both work when I tested it manually on 26.2 on an M2.Missing is code signing so currently users need to execute
xattr -cron the binaries.Any preferences here on how to approach this, e.g.
xattr -cr?codesign?codesignbacked by a real developer id?Open issues: