Determine the page size on Android from NDK header files#69
Merged
lexprfuncall merged 1 commit intofacebook:devfrom Jan 21, 2026
Merged
Determine the page size on Android from NDK header files#69lexprfuncall merged 1 commit intofacebook:devfrom
lexprfuncall merged 1 commit intofacebook:devfrom
Conversation
lexprfuncall
force-pushed
the
fix-android-page-size
branch
from
1f11e11 to
bf8c7db
Compare
Author
|
I tested this change by downloading the r27d (LTS) and r29 (latest) releases of the NDK and followed the autoconf recipe provided here https://developer.android.com/ndk/guides/other_build_systems#autoconf on the product of 32-bit and 64-bit versions of ARM and x86 and the r27d and r29 releases of the NDK. When using NDK r27d with a TARGET of aarch64-linux-android or x86_64-linux-android LG_PAGE is 12. If I changed the release of the NDK to r29, LG_PAGE is 14. Irrespective of the NDK release LG_PAGE is always 12 when the TARGET is armv7a-linux-androideabi or i686-linux-android. As usual, the --with-lg-page flag to ./configure explicitly specifies the page size. |
lexprfuncall
force-pushed
the
fix-android-page-size
branch
from
bf8c7db to
8202c47
Compare
The definition of the PAGE_SIZE macro is used as a signal for a 32-bit target or a 64-bit target with an older NDK. Otherwise, a 16KiB page size is assumed. Resolves jemalloc#2657
lexprfuncall
force-pushed
the
fix-android-page-size
branch
from
8202c47 to
51ba716
Compare
spredolac
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The definition of the PAGE_SIZE macro is used as a signal for a 32-bit target or a 64-bit target with an older NDK. Otherwise, a 16KiB page size is assumed.
Resolves jemalloc#2657