refactor: use WaitGroup.Go to simplify code

[jiangmencity]

Overview

use WaitGroup.Go to simplify code. More info: golang/go#63796

[gemini-code-assist]

Summary of Changes

Hello @jiangmencity, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors existing goroutine management by introducing the sync.WaitGroup.Go helper function. This change streamlines the code responsible for starting and tracking concurrent operations, making it more concise and aligned with modern Go best practices. The primary goal is to simplify the codebase and improve maintainability by reducing boilerplate around WaitGroup usage.

Highlights

• Code Simplification: Replaced the manual sync.WaitGroup management pattern (explicit Add(1) and defer Done()) with the more concise and idiomatic WaitGroup.Go helper function across several goroutine launches.
• Improved Concurrency Pattern: Adopted the WaitGroup.Go pattern for launching goroutines, which enhances readability and reduces boilerplate code for common concurrent tasks.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• block/internal/executing/executor.go
  • Refactored the goroutine launch for the executionLoop to use e.wg.Go.
• block/internal/reaping/reaper.go
  • Refactored the goroutine launch for the reaperLoop to use r.wg.Go.
• block/internal/syncing/raft_retriever.go
  • Refactored the goroutine launch for the raftApplyLoop to use r.wg.Go.
• pkg/da/selector_test.go
  • Refactored goroutine launches within TestNoOpSelector_Concurrent to use wg.Go.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the code to use sync.WaitGroup.Go, which simplifies goroutine management. The changes are applied consistently across executor.go, reaper.go, raft_retriever.go, and selector_test.go, replacing the more verbose pattern of wg.Add(1), go func(), and defer wg.Done() with a single call to wg.Go(). This is a good improvement for code clarity and conciseness. The implementation is correct and I have no further suggestions.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.92%. Comparing base (a64c35b) to head (bb0c294).
⚠️ Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
block/internal/syncing/raft_retriever.go	0.00%	2 Missing ⚠️
block/internal/executing/executor.go	0.00%	1 Missing ⚠️
block/internal/reaping/reaper.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3059      +/-   ##
==========================================
+ Coverage   61.64%   61.92%   +0.28%     
==========================================
  Files         111      111              
  Lines       11120    11113       -7     
==========================================
+ Hits         6855     6882      +27     
+ Misses       3526     3492      -34     
  Partials      739      739              

Flag	Coverage Δ
combined	61.92% <0.00%> (+0.28%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jiangmencity]

@julienrbrt Thank you for your review!

Modified. Please review it again.