Open
Conversation
Codecov Report
@@ Coverage Diff @@
## main #43 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 666 693 +27
Branches 79 84 +5
=========================================
+ Hits 666 693 +27
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Owner
|
Hey @challet ! Thanks for the PR 🙏🏻 I'm a bit busy these day, but I will look at it as soon as possible 👍🏻 |
Contributor
Author
|
Hi @enzoferey, you're welcome. When you have time, I would be glad to have your opinion on it : the error format I'm testing comes from a Ganache backend and I'm not totally confident it would work everywhere. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is your pull request closing an issue?
No
Please explain the main changes of your pull request
ether.js Contract.deployed function can throw an error about the contract not being deployed.
This adds a new error type
CONTRACT_NOT_DEPLOYEDfor this case with the address having been requested as a context.Checklist