Add button to automatically pair up relocs#314
Open
dbalatoni13 wants to merge 3 commits intoencounter:mainfrom
Open
Add button to automatically pair up relocs#314dbalatoni13 wants to merge 3 commits intoencounter:mainfrom
dbalatoni13 wants to merge 3 commits intoencounter:mainfrom
Conversation
LagoLunatic
reviewed
Dec 31, 2025
Owner
|
Looks good, but I wonder if we should try to throw it in a dropdown and make it more descriptive: maybe "Auto-map symbols" with tooltip "Automatically create symbol mappings based on relocation diffs" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #310
It goes through the diff rows of a function and tries to find potential pairings. Ambigous pairings are not applied. The button is disabled if name relocation diffs are disabled.