Open
Conversation
Author
|
The new coverage misses are a bit 🤷, because evidently those cases weren't tested previously either, they were just conveniently covered by the exception mapping 😄 |
`try: except:` blocks are free on modern Pythons when exceptions aren't raised. Entering a `@contextmanager`'d block is much less free, and there are hot paths (e.g. reading from a sync socket) where it's worth avoiding that overhead. For consistency, this retires the use of `map_exceptions` everywhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
try: except:blocks are free on modern Pythons when exceptions aren't raised.Entering a
@contextmanager'dwithblock is much less free (see e.g. this Django discussion aboutcontextlib.suppress), and there are hot paths (e.g. reading from a sync socket) where it's worth avoiding that overhead.For consistency, this retires the use of
map_exceptionseverywhere.Checklist
Performance impact
Using
pytest-benchmark, and Caddy locally serving a 10-megabyte file,is shown to be a bit faster: