Fix: allow root user to view details and manage all processes#527
Open
heavenly999 wants to merge 1 commit intoelementary:mainfrom
Open
Fix: allow root user to view details and manage all processes#527heavenly999 wants to merge 1 commit intoelementary:mainfrom
heavenly999 wants to merge 1 commit intoelementary:mainfrom
Conversation
Add Process.is_own property that accounts for root having full access to all processes. Previously, uid comparison alone caused the detail pane to be hidden and kill/end buttons disabled for non-root processes when the app was run as root.
Member
|
This is not incorrect. Monitor is not designed to run as root. How frequently do you run Monitor as root? |
Author
|
Occasionally, 2-3 times per month. Usually to track down, debug or stop misbehaving processes. |
Member
|
What system processes are misbehaving? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Process.is_ownproperty that centralizes the ownership/access check, accounting for root having full access to all processesuid == Posix.getuid()comparisons across the codebaseProblem
When running Monitor as root, the detail pane was hidden and the kill/end buttons were disabled for processes owned by other users (e.g. uid 1000). This is incorrect — root has full access to
/procdata and can send signals to any process.Changes
Process.vala: Addis_owncomputed property — returnstruewhen the process belongs to the current user OR when running as rootProcessInfoView.vala: Use!_process.is_owninstead of raw uid comparison for detail pane visibilityProcessView.vala: Useprocess.is_ownfor kill/end button enabling