refactor(amp-worker-core): rename dump crate and move streaming_query to common #1723
+183
−189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Complete the dump crate split (PR 3/3) by renaming the residual shared infrastructure to amp-worker-core and relocating streaming_query into common so server no longer depends on worker internals. - Rename `crates/core/dump` to `crates/core/worker-core` (package `amp-worker-core`) - Move `streaming_query` module from dump to `common` crate - Remove `server` dependency on dump (now uses `common::streaming_query`) - Update all consumer imports (`use dump::` → `use amp_worker_core::`) - Remove 6 unused deps from worker-core that only streaming_query needed Signed-off-by: Mitchell Spencer <mitchellhspencer@gmail.com>
Align documentation with the completed 3-PR dump crate split by replacing all stale crate names and file paths. - Replace `crates/core/dump/` paths with `crates/core/worker-core/` or `crates/core/common/` as appropriate - Remove `crate:dump` from feature doc component metadata since server no longer depends on it - Add `worker-datasets-raw` and `worker-datasets-derived` to workspace crate listing - Fix stale `query.rs` source reference in query-sql-batch feature doc Signed-off-by: Mitchell Spencer <mitchellhspencer@gmail.com>
Contributor
|
Can we split this PR into 2 smaller PRs? One for moving streaming query logic and another for renaming the crate? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR 3 of the dump crate split series (final).
Renames the residual
dumpcrate toamp-worker-coreand relocatesstreaming_queryintocommon, completing the decoupling started in #1716 and #1720.crates/core/dumptocrates/core/worker-core(packageamp-worker-core).streaming_querymodule from dump tocommoncrate soserverno longer depends on worker internals.use dump::→use amp_worker_core::,use dump::streaming_query→use common::streaming_query).worker-corethat onlystreaming_queryneeded.Closes #1700