fix: support multi-network segment chains #1722
Open
+288
−103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Theodus
force-pushed
the
theodus/multi-network
branch
from
d6ed284 to
0e2b31f
Compare
LNSD
approved these changes
Feb 11, 2026
Contributor
LNSD
left a comment
LNSD
left a comment
There was a problem hiding this comment.
LGTM ✅
There are some implementation details, but in general, LGTM.
Comment on lines
+467
to
+469
| /// Multi-network canonical chain not supported with start block | ||
| #[error("multi-network datasets with start_block are not supported")] | ||
| MultiNetworkWithStartBlock, |
Contributor
There was a problem hiding this comment.
Does this mean that multi-chain joins need to sync the whole history?
Comment on lines
+256
to
+259
| // Invariant: this function only works for single-network segments (raw datasets) | ||
| if let Some(first_segment) = segments.first() { | ||
| assert_eq!(first_segment.ranges.len(), 1); | ||
| } |
Contributor
There was a problem hiding this comment.
Would it be possible that we bake these invariants into the typesystem?
I'm not asking to do it as part of this PR, just asking if it is possible.
| // remove overlapping ranges from each segment | ||
| for segment in &segments { | ||
| let segment_range = segment.range.numbers.clone(); | ||
| assert_eq!(segment.ranges.len(), 1); |
Contributor
There was a problem hiding this comment.
Are we running through this assertion in all the segments? Spooky! 😨
Why don't we just tracing::error and skip the segment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the segment selection algorithm to support multi-network segments. Call sites will continue to depend on there only being single-network segments for now.