Skip to content

[FIX] fix NPE when disposing not yet used ZWPS Code Mining#3773

Merged
iloveeclipse merged 1 commit intoeclipse-platform:masterfrom
marcushoepfner:fix-zwsp-npe
Mar 13, 2026
Merged

[FIX] fix NPE when disposing not yet used ZWPS Code Mining#3773
iloveeclipse merged 1 commit intoeclipse-platform:masterfrom
marcushoepfner:fix-zwsp-npe

Conversation

@marcushoepfner
Copy link
Contributor

@marcushoepfner marcushoepfner commented Mar 12, 2026

Fixes: #3772

@github-actions
Copy link
Contributor

Test Results

 2 910 files  +2 058   2 910 suites  +2 058   1h 59m 54s ⏱️ + 1h 5m 55s
 7 708 tests  -   140   7 460 ✅  -   145  248 💤 +  5  0 ❌ ±0 
21 948 runs  +1 878  21 153 ✅ +1 739  795 💤 +139  0 ❌ ±0 

Results for commit 4902d09. ± Comparison against base commit 9c4efac.

This pull request removes 5940 and adds 5800 tests. Note that renamed tests count towards both.
UiTestSuite ‑ Unknown test
org.eclipse.core.filebuffers.tests.ConvertLineDelemiterTest ‑ testWithDelimnAtEnd
org.eclipse.core.filebuffers.tests.ConvertLineDelemiterTest ‑ testWithoutDelimnAtEnd
org.eclipse.core.filebuffers.tests.FileBufferCreation ‑ test1
org.eclipse.core.filebuffers.tests.FileBufferCreation ‑ test1_IFILE
org.eclipse.core.filebuffers.tests.FileBufferCreation ‑ test1_IFileStore
org.eclipse.core.filebuffers.tests.FileBufferCreation ‑ test2
org.eclipse.core.filebuffers.tests.FileBufferCreation ‑ test2_new
org.eclipse.core.filebuffers.tests.FileBufferCreation ‑ test3_1
org.eclipse.core.filebuffers.tests.FileBufferCreation ‑ test3_1_IFILE
…
AllFormsTests AllEventsTests ExpansionListenerTest ‑ callsExpansionStateChangedConsumer
AllFormsTests AllEventsTests ExpansionListenerTest ‑ callsExpansionStateChangingConsumer
AllFormsTests AllEventsTests ExpansionListenerTest ‑ throwsNullPointerOnNullStateChangedAdapter
AllFormsTests AllEventsTests ExpansionListenerTest ‑ throwsNullPointerOnNullStateChangingAdapter
AllFormsTests AllEventsTests HyperLinkListenerTest ‑ callsActivatedConsumer
AllFormsTests AllEventsTests HyperLinkListenerTest ‑ callsEnteredConsumer
AllFormsTests AllEventsTests HyperLinkListenerTest ‑ callsExitedConsumer
AllFormsTests AllEventsTests HyperLinkListenerTest ‑ throwsNullPointerOnNullActivatedAdapter
AllFormsTests AllEventsTests HyperLinkListenerTest ‑ throwsNullPointerOnNullEnteredAdapter
AllFormsTests AllEventsTests HyperLinkListenerTest ‑ throwsNullPointerOnNullExitedAdapter
…
This pull request removes 119 skipped tests and adds 119 skipped tests. Note that renamed tests count towards both.
UiTestSuite ‑ Unknown test
org.eclipse.e4.ui.tests.workbench.MWindowTest ‑ TODOtestWindow_X
org.eclipse.e4.ui.tests.workbench.MWindowTest ‑ TODOtestWindow_Y
org.eclipse.e4.ui.tests.workbench.ModelAssemblerTests ‑ testFragments_existingXMIID_checkExists
org.eclipse.e4.ui.tests.workbench.PartRenderingEngineTests ‑ TODOtestBug326175_True
org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRendererTest ‑ testMMenu_ToBeRendered
org.eclipse.jface.tests.fieldassist.ControlDecorationTests ‑ testBug418420
org.eclipse.jface.text.tests.MultiSelectionTest ‑ testViewer
org.eclipse.jface.text.tests.contentassist.FilteringAsyncContentAssistTests ‑ testFastCompletionsNotFilteredUntilLongComplitionsCalculated
org.eclipse.search.tests.filesearch.SearchResultPageTest ‑ testBasicDisplay
…
AllSearchTests AllFileSearchTests SearchResultPageTest ‑ testBasicDisplay
AllSearchTests AllFileSearchTests SearchResultPageTest ‑ testRemoveTreeMatches
AllTests FieldAssistTestSuite ControlDecorationTests ‑ testBug418420
EclipseTextTestSuite FindReplaceDocumentAdapterTest ‑ _testRegexFindLinebreak2
EclipseTextTestSuite FindReplaceDocumentAdapterTest ‑ _testRegexReplace
JFaceTextTestSuite FilteringAsyncContentAssistTests ‑ testFastCompletionsNotFilteredUntilLongComplitionsCalculated
JFaceTextTestSuite MultiSelectionTest ‑ testViewer
NavigatorTestSuite FoldersAsProjectsContributionTest ‑ alreadyAdded
NavigatorTestSuite FoldersAsProjectsContributionTest ‑ notYetImported
RcpTestSuite PlatformUITest ‑ testCreateAndRunWorkbenchWithExceptionOnStartup
…
This pull request skips 5 tests.
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testEnabledWhenHover(TestInfo)
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testMultipleHover(TestInfo)
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testProblemHover(TestInfo)
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testSingleHover(TestInfo)
org.eclipse.ui.genericeditor.tests.ShowInformationTest ‑ testInformationControl(TestInfo)

@iloveeclipse
Copy link
Member

Tycho build fails on the code that is fully unrelated:

12:30:48.627 [ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:5.0.3-SNAPSHOT:compile (default-compile) on project org.eclipse.core.filebuffers.tests: Compilation failure: Compilation failure: 
12:30:48.627 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileBufferFunctions.java:[431] 
12:30:48.627 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.627 [ERROR] 	^^^^^^^^^
12:30:48.627 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.627 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileBufferFunctions.java:[482] 
12:30:48.627 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.627 [ERROR] 	^^^^^^^^^
12:30:48.627 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.627 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileBufferFunctions.java:[635] 
12:30:48.627 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.627 [ERROR] 	^^^^^^^^^
12:30:48.627 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.627 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileBufferFunctions.java:[681] 
12:30:48.627 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.627 [ERROR] 	^^^^^^^^^
12:30:48.627 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.627 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileBufferFunctions.java:[728] 
12:30:48.627 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.627 [ERROR] 	^^^^^^^^^
12:30:48.627 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.627 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileBufferFunctions.java:[775] 
12:30:48.627 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileBufferFunctions.java:[822] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileBufferFunctions.java:[865] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileBufferFunctions.java:[918] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileBufferFunctions.java:[959] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileBufferFunctions.java:[1000] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileBufferFunctions.java:[1041] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileBufferFunctions.java:[1083] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileBufferFunctions.java:[1126] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileBuffersForWorkspaceFiles.java:[98] 
12:30:48.628 [ERROR] 	assertAll(() -> assertTrue(iFile.exists()), () -> assertTrue(iFile.getFullPath().equals(getPath())));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileStoreFileBufferFunctions.java:[422] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileStoreFileBufferFunctions.java:[473] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileStoreFileBufferFunctions.java:[626] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileStoreFileBufferFunctions.java:[672] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileStoreFileBufferFunctions.java:[719] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileStoreFileBufferFunctions.java:[766] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileStoreFileBufferFunctions.java:[813] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileStoreFileBufferFunctions.java:[856] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileStoreFileBufferFunctions.java:[899] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileStoreFileBufferFunctions.java:[940] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileStoreFileBufferFunctions.java:[981] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileStoreFileBufferFunctions.java:[1022] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileStoreFileBufferFunctions.java:[1064] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileStoreFileBufferFunctions.java:[1107] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileStoreFileBuffersForWorkspaceFiles.java:[98] 
12:30:48.628 [ERROR] 	assertAll(() -> assertTrue(iFile.exists()), () -> assertTrue(iFile.getFullPath().equals(getPath())));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError

It looks like tycho can't find org.opentest4j, probably infra issues again? See https://ci.eclipse.org/platform/job/eclipse.platform.ui/job/PR-3773/1/consoleText.

I've restarted.

@marcushoepfner
Copy link
Contributor Author

Tycho build fails on the code that is fully unrelated:

12:30:48.627 [ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:5.0.3-SNAPSHOT:compile (default-compile) on project org.eclipse.core.filebuffers.tests: Compilation failure: Compilation failure: 
12:30:48.627 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileBufferFunctions.java:[431] 
12:30:48.627 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.627 [ERROR] 	^^^^^^^^^
12:30:48.627 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.627 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileBufferFunctions.java:[482] 
12:30:48.627 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.627 [ERROR] 	^^^^^^^^^
12:30:48.627 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.627 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileBufferFunctions.java:[635] 
12:30:48.627 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.627 [ERROR] 	^^^^^^^^^
12:30:48.627 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.627 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileBufferFunctions.java:[681] 
12:30:48.627 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.627 [ERROR] 	^^^^^^^^^
12:30:48.627 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.627 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileBufferFunctions.java:[728] 
12:30:48.627 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.627 [ERROR] 	^^^^^^^^^
12:30:48.627 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.627 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileBufferFunctions.java:[775] 
12:30:48.627 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileBufferFunctions.java:[822] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileBufferFunctions.java:[865] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileBufferFunctions.java:[918] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileBufferFunctions.java:[959] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileBufferFunctions.java:[1000] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileBufferFunctions.java:[1041] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileBufferFunctions.java:[1083] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileBufferFunctions.java:[1126] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileBuffersForWorkspaceFiles.java:[98] 
12:30:48.628 [ERROR] 	assertAll(() -> assertTrue(iFile.exists()), () -> assertTrue(iFile.getFullPath().equals(getPath())));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileStoreFileBufferFunctions.java:[422] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileStoreFileBufferFunctions.java:[473] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileStoreFileBufferFunctions.java:[626] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileStoreFileBufferFunctions.java:[672] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileStoreFileBufferFunctions.java:[719] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileStoreFileBufferFunctions.java:[766] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileStoreFileBufferFunctions.java:[813] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileStoreFileBufferFunctions.java:[856] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileStoreFileBufferFunctions.java:[899] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileStoreFileBufferFunctions.java:[940] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileStoreFileBufferFunctions.java:[981] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileStoreFileBufferFunctions.java:[1022] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileStoreFileBufferFunctions.java:[1064] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileStoreFileBufferFunctions.java:[1107] 
12:30:48.628 [ERROR] 	assertAll(() -> assertEquals(0, listener.count), () -> assertNull(listener.buffer));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError
12:30:48.628 [ERROR] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-3773/tests/org.eclipse.core.filebuffers.tests/src/org/eclipse/core/filebuffers/tests/FileStoreFileBuffersForWorkspaceFiles.java:[98] 
12:30:48.628 [ERROR] 	assertAll(() -> assertTrue(iFile.exists()), () -> assertTrue(iFile.getFullPath().equals(getPath())));
12:30:48.628 [ERROR] 	^^^^^^^^^
12:30:48.628 [ERROR] The method assertAll(Executable...) from the type Assertions refers to the missing type MultipleFailuresError

It looks like tycho can't find org.opentest4j, probably infra issues again? See https://ci.eclipse.org/platform/job/eclipse.platform.ui/job/PR-3773/1/consoleText.

I've restarted.

I have also seen this.

Shall I merge regardless of the build result @iloveeclipse ?

@iloveeclipse
Copy link
Member

Shall I merge regardless of the build result @iloveeclipse ?

Even if the PR / fix is trivial & errors seem to be unrelated, please don't merge yet.
All builds are failing (jenkins + github), this shouldn't happen. Looks like some tycho issue.

I've pushed #3774, if this shows same issue, it's tycho/maven problem.

@merks
Copy link
Contributor

merks commented Mar 12, 2026

My p2 PR fails for strange reasons too:

https://ci.eclipse.org/equinox/job/p2/job/PR-1051/1/consoleFull

@iloveeclipse
Copy link
Member

My p2 PR fails for strange reasons too:

https://ci.eclipse.org/equinox/job/p2/job/PR-1051/1/consoleFull

[ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:5.0.3-SNAPSHOT:compile (default-compile) on project org.eclipse.equinox.p2.artifact.repository: Compilation failure: Compilation failure: 
08:50:57  [ERROR] /home/jenkins/agent/workspace/p2_PR-1051/bundles/org.eclipse.equinox.p2.artifact.repository/src/org/eclipse/equinox/internal/p2/artifact/processors/pgp/PGPPublicKeyStore.java:[100] 
08:50:57  [ERROR] 	new JcaPGPObjectFactory(stream).forEach(o -> {
08:50:57  [ERROR] 	                                ^^^^^^^
08:50:57  [ERROR] The method forEach((<no type> o) -> {}) is undefined for the type JcaPGPObjectFactory
08:50:57  [ERROR] /home/jenkins/agent/workspace/p2_PR-1051/bundles/org.eclipse.equinox.p2.artifact.repository/src/org/eclipse/equinox/internal/p2/artifact/processors/pgp/PGPPublicKeyStore.java:[120] 
08:50:57  [ERROR] 	pgpPublicKeyRingCollection.forEach(keyring -> collectKeys(keyring, collector));
08:50:57  [ERROR] 	                           ^^^^^^^
08:50:57  [ERROR] The method forEach((<no type> keyring) -> {}) is undefined for the type PGPPublicKeyRingCollection
08:50:57  [ERROR] /home/jenkins/agent/workspace/p2_PR-1051/bundles/org.eclipse.equinox.p2.artifact.repository/src/org/eclipse/equinox/internal/p2/artifact/processors/pgp/PGPPublicKeyStore.java:[123] 
08:50:57  [ERROR] 	private static void collectKeys(PGPPublicKeyRing pgpPublicKeyRing, Consumer<PGPPublicKey> collector) {
08:50:57  [ERROR] 	                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
08:50:57  [ERROR] The method collectKeys(PGPPublicKeyRing, Consumer<PGPPublicKey>) from the type PGPPublicKeyStore is never used locally

Same problem.
@laeubi : was there any tycho 5.0.3-snapshot change recently?

@iloveeclipse
Copy link
Member

Created eclipse-tycho/tycho#5922.

@iloveeclipse
Copy link
Member

OK, the builds are broken for everyone now, this change is safe, so let's merge.

@iloveeclipse iloveeclipse merged commit ad897dc into eclipse-platform:master Mar 13, 2026
10 of 17 checks passed
@merks
Copy link
Contributor

merks commented Mar 13, 2026

@iloveeclipse

Are you certain that by skipping the build verification you are not also skipping the automated version bump to which we've all grown accustomed?

image

I mentioned that because I don't see a MANIFEST.MF bump in the history for the affected bundle. Should there be one?

@iloveeclipse
Copy link
Member

Are you certain that by skipping the build verification you are not also skipping the automated version bump to which we've all grown accustomed?

Yes, the feature was just recently merged via b8d7d92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NPE in ZeroWidthCharactersLineContentCodeMiningProvider.dispose()

4 participants