Fix logging level in background session log calls#456
Open
jcarroll3 wants to merge 1 commit intodropbox:masterfrom
Open
Fix logging level in background session log calls#456jcarroll3 wants to merge 1 commit intodropbox:masterfrom
jcarroll3 wants to merge 1 commit intodropbox:masterfrom
Conversation
jcarroll3
force-pushed
the
log_levels
branch
from
f121e13 to
9ea4bc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
LogHelper.logBackgroundSession(::) accepts a level parameter for callers that want to log at a level different from the default backgroundSessionLogLevel (the doc comment explicitly says: "For logging something background-session related at a different level than backgroundSessionLogLevel, such as .error"). However, the implementation was ignoring level and always passing backgroundSessionLogLevel to log().
This change passes the caller-supplied level through to log() as intended.