Move null checking to compiler-side using nullable annotations#1530
Open
alinpahontu2912 wants to merge 1 commit intodotnet:mainfrom
Open
Move null checking to compiler-side using nullable annotations#1530alinpahontu2912 wants to merge 1 commit intodotnet:mainfrom
alinpahontu2912 wants to merge 1 commit intodotnet:mainfrom
Conversation
Member
alinpahontu2912
commented
Feb 13, 2026
alinpahontu2912
commented
- Remove redundant runtime null checks from non-nullable Parameter weight setters in Linear, Bilinear, Convolution, PReLU, GroupNorm, LayerNorm, and NormBase (already enforced by #nullable enable)
- Add [DisallowNull] to Parameter? properties in RNNCell, LSTMCell, GRUCell, Embedding, and EmbeddingBag where getter can return null but setter must not accept null
- Enable #nullable enable in Transforms.cs and remove runtime null check from ComposeTransform constructor
- Remove runtime null check from Module.get_buffer() (string parameter is non-nullable under #nullable enable)
- Add DisallowNullAttribute polyfill in netstandard.cs for netstandard2.0 compatibility
- Remove redundant runtime null checks from non-nullable Parameter weight setters in Linear, Bilinear, Convolution, PReLU, GroupNorm, LayerNorm, and NormBase (already enforced by #nullable enable) - Add [DisallowNull] to Parameter? properties in RNNCell, LSTMCell, GRUCell, Embedding, and EmbeddingBag where getter can return null but setter must not accept null - Enable #nullable enable in Transforms.cs and remove runtime null check from ComposeTransform constructor - Remove runtime null check from Module.get_buffer() (string parameter is non-nullable under #nullable enable) - Add DisallowNullAttribute polyfill in netstandard.cs for netstandard2.0 compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.