Add github CI, fix cmake test definition#152
Open
thelema wants to merge 10 commits intodocopt:masterfrom
Open
Conversation
This is borrowed/stolen from @ClausKlein's commit
Author
|
Let me know if you want the history on this cleaned up. I'm expecting this to be squash-merged into your repo. |
stephan-cr
reviewed
Mar 30, 2022
Author
|
@jaredgrubb any chance of getting this merged? |
Member
|
I haven't used GitHub CI before .. how will this appear once merged? |
|
@jaredgrubb You get a checkmark next to a verified commit, You can inspect the build and logs for set amount of time theyre available, in the build it's pretty standard, You get step rundown with logs and success/failures. Every Pull Request will have CI rundown for each new update. Here's a short introduction video. |
Member
|
So once we merge this, it'll just kick in? or is there further setup that I'll need to do? Thanks for the idea on this! |
Author
|
Yes, on pushes and pull-requests to master branch, this will automatically
trigger and run a regression, reporting results.
Eric
…On Thu, May 19, 2022, 3:04 PM Jared Grubb ***@***.***> wrote:
So once we merge this, it'll just kick in? or is there further setup that
I'll need to do?
Thanks for the idea on this!
—
Reply to this email directly, view it on GitHub
<#152 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAPDCCAO3JALODU5VEQI3VK23GPANCNFSM5RXVJRNA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
This looks like a great idea and a good implementation to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds github CI support so master and branches can be regressed automatically against existing tests.