Draft
Conversation
rprospero
reviewed
Jun 21, 2024
Contributor
rprospero
left a comment
rprospero
left a comment
There was a problem hiding this comment.
It looks like a good framework, but I had some thoughts on how we could get more type safety and reusability from the code.
| }; | ||
|
|
||
| // Index / Column ID, Name / Column Title, Data Type, ReadOnly? | ||
| using DataItemProperty = std::tuple<int, std::string, PropertyType, Flags<PropertyFlag>>; |
Contributor
There was a problem hiding this comment.
I think that this might be a bit clearer as a struct. That would allow us to do diProp.index instead of std::get<0>(diProp). Of course, we could still overload std::get if we really needed to.
Member
Author
There was a problem hiding this comment.
Ah, for sure! I was using the std::tuple just to quickly spin up a working example, although all the std::get<> pollution quickly became rather tiresome. struct or class definitely the way to go.
trisyoungs
force-pushed
the
1912-create-delete-parameters
branch
from
6b55320 to
84f684c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rprospero here is the stuff I came up with when looking into custom model interfaces. Still uses a template class sitting alongside the data (here focussing just on
std::vectorand tables) but the template derives from a concrete base class which the Qt model leverages to do all the work.Thoughts on how any of this (if any!) can work with your own approach welcome!