Skip to content

Conversation

@spomichter
Copy link
Contributor

No description provided.

@greptile-apps
Copy link

greptile-apps bot commented Feb 12, 2026

Greptile Overview

Greptile Summary

This PR adds Jetson Jetpack 6.2 (CUDA 12.6) support for ARM64 platforms, along with several quality-of-life improvements for testing and documentation.

Key Changes:

  • Added Jetson JP6 CUDA 12.6 support via custom PyPI index at pypi.jetson-ai-lab.io
  • Switched to open3d-unofficial-arm for ARM platforms (falls back to standard open3d on x86)
  • Pinned langchain and langchain-core to version 1.2.3 for stability
  • Added lazy_loader as a core dependency
  • Expanded CUDA extra with Detic GPU stack dependencies (mss, ftfy, regex, fasttext, lvis, nltk, clip, detectron2)
  • Created new bin/test Deno script for intelligent test execution with caching and marker filtering
  • Updated README with clearer Jetson installation instructions
  • Added @pytest.mark.neverending to webcam test to prevent it from running in CI

Issues Found:

  • Minor spelling error: reccomendedrecommended in README.md:110

Confidence Score: 4/5

  • This PR is safe to merge with one minor spelling fix needed
  • Score reflects solid infrastructure improvements for Jetson support with only a trivial spelling error. The dependency changes are well-contained with proper platform markers, the test improvements add value, and the lockfile is properly updated. The custom Jetson index adds some external dependency risk, but the changes are backward-compatible for non-ARM platforms.
  • README.md requires a quick spelling fix on line 110

Important Files Changed

Filename Overview
README.md Updated installation instructions for Jetson support with better clarity; minor spelling error on line 110
bin/test Added new Deno-based test runner with caching, marker filtering, and timeout support
pyproject.toml Added Jetson JP6 support, pinned langchain versions, added lazy_loader dependency, switched to open3d-unofficial-arm for ARM platforms, added Detic GPU stack dependencies

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile


#### Install dependencies
```bash
# CPU only (reccomended to attempt first)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reccomended is misspelled

Suggested change
# CPU only (reccomended to attempt first)
# CPU only (recommended to attempt first)

"lvis",
"nltk",
"clip",
"detectron2",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeff-hykin why is dectron added back here

Copy link
Member

@jeff-hykin jeff-hykin Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cause I have an actual "Add Arm Support" PR #1229 is the latest and up to date with dev

This branch was never suppost to be a PR and its stale, it has junk in it and was just so you could do a quick test

@jeff-hykin jeff-hykin closed this Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants