Skip to content

Add check if 'link' in options is instance of dict.#233

Draft
mielvds wants to merge 1 commit intomasterfrom
link-circular-refs
Draft

Add check if 'link' in options is instance of dict.#233
mielvds wants to merge 1 commit intomasterfrom
link-circular-refs

Conversation

@mielvds
Copy link
Collaborator

@mielvds mielvds commented Jan 20, 2026

An empty dict is not truthy in python, so cannot just check
for "if options['link']"

Fixes #64
Replaces #66 because it was too outdated for a merge.

@mielvds
Copy link
Collaborator Author

mielvds commented Jan 20, 2026

This PR introduces a regression in the framing implementation. While the use of options['link'] is error-prone, the current code somehow relies on this side-effect. Further investigation is needed before this becomes an actual fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

framing with "@embed": "@link" cannot handle circular references

1 participant