Update to Kotest 6.1.0 and refactor to align with updated API changes.#559
Update to Kotest 6.1.0 and refactor to align with updated API changes.#559sksamuel wants to merge 5 commits intodiffplug:mainfrom
Conversation
|
Thanks very much for this implementation! Looks like you need to run I can update the changelogs myself, but I need an update to this file
The |
|
Spotless applied and docs updated. Let me know if you need further changes! |
|
I must be missing something locally as it has been green locally each time. Hopefully this last commit has it fixed on CI too. |
|
fwiw: selfie/.github/workflows/jvm-ci.yml Line 35 in e306baa The build can be a bit finnicky, tests that run tests seem to hit edge cases in Gradle. |
|
Gotcha, no big deal if you don't mind hitting approve each time to run the tests :) |
|
I got it to fail locally now. |
| val coroutineLocal = CoroutineDiskStorage(DiskStorageJUnit5(file, testCase.name.name)) | ||
| return withContext(currentCoroutineContext() + coroutineLocal) { | ||
| file.startTest(testCase.name.testName, false) | ||
| file.startTest(testCase.name.name, false) | ||
| val result = execute(testCase) | ||
| file.finishedTestWithSuccess(testCase.name.testName, false, result.isSuccess) | ||
| file.finishedTestWithSuccess(testCase.name.name, false, result.isSuccess) |
There was a problem hiding this comment.
The expression testCase.name.name is repeated, could it be worth extracting a variable?
| file.startTest(it.key.name.name, false) | ||
| file.finishedTestWithSuccess(it.key.name.name, false, false) |
| file.startTest(it.key.name.name) | ||
| file.finishedTestWithSuccess(it.key.name.name, false) |
3 participants
Kotest 6 was a major release with some small breaking changes to the API.
This PR updates the code and examples to reflect the changes.