Fix XML rendering crash with non-printable characters#8806
Open
tautschnig wants to merge 1 commit intodiffblue:developfrom
Open
Fix XML rendering crash with non-printable characters#8806tautschnig wants to merge 1 commit intodiffblue:developfrom
tautschnig wants to merge 1 commit intodiffblue:developfrom
Conversation
Handle non-printable characters in XML attributes by escaping them as numeric character references instead of aborting. Co-authored-by: Kiro autonomous agent Fixes: diffblue#7073
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8806 +/- ##
========================================
Coverage 80.00% 80.01%
========================================
Files 1700 1700
Lines 188249 188277 +28
Branches 73 73
========================================
+ Hits 150615 150643 +28
Misses 37634 37634 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
My understanding is that this is still invalid XML. So we either error, or produce invalid XML. |
Collaborator
|
To make progress, how about encoding the null-character as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle non-printable characters in XML attributes by escaping them as numeric character references instead of aborting.
Co-authored-by: Kiro autonomous agent
Fixes: #7073