Skip to content

fix(sns): Pass additional_critical_native_action_ids in SNS initialization flow#8752

Merged
jasonz-dfinity merged 3 commits intomasterfrom
jason/custom-proposal-criticality-fix
Feb 10, 2026
Merged

fix(sns): Pass additional_critical_native_action_ids in SNS initialization flow#8752
jasonz-dfinity merged 3 commits intomasterfrom
jason/custom-proposal-criticality-fix

Conversation

@jasonz-dfinity
Copy link
Contributor

Why

In the previous PR #8686 a new field additional_critical_native_action_ids was added to SNS. However, it wasn't added to SnsInitPayload so it was not passed through the NNS Governance => SNS W => SNS Governance in the initialization flow.

What

  • Add a pocket IC test:
    • Tests the initialization flow - an SNS initialized with the action ids have additional critical proposal types
    • Tests updating of the list - the SNS can still remove critical proposal types afterwards
    • This test fails (as expected) without the fix in the second commit
  • Add the new field to SnsInitPayload, and implement the conversions CreateServiceNervousSystem=>SnsInitPayload=>NervousSystemParameters

@jasonz-dfinity jasonz-dfinity requested a review from a team as a code owner February 9, 2026 20:44
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):

  1. Update unreleased_changelog.md (if there are behavior changes, even if they are
    non-breaking).

  2. Are there BREAKING changes?

  3. Is a data migration needed?

  4. Security review?

How to Satisfy This Automatic Review

  1. Go to the bottom of the pull request page.

  2. Look for where it says this bot is requesting changes.

  3. Click the three dots to the right.

  4. Select "Dismiss review".

  5. In the text entry box, respond to each of the numbered items in the previous
    section, declare one of the following:

  • Done.

  • $REASON_WHY_NO_NEED. E.g. for unreleased_changelog.md, "No
    canister behavior changes.", or for item 2, "Existing APIs
    behave as before.".

Brief Guide to "Externally Visible" Changes

"Externally visible behavior change" is very often due to some NEW canister API.

Changes to EXISTING APIs are more likely to be "breaking".

If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.

If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.

Reference(s)

For a more comprehensive checklist, see here.

GOVERNANCE_CHECKLIST_REMINDER_DEDUP

@github-actions github-actions bot added the fix label Feb 9, 2026
@jasonz-dfinity jasonz-dfinity dismissed github-actions[bot]’s stale review February 9, 2026 22:49
  1. No need as the previous PR already added one
  2. Not breaking
  3. No impact on existing data
  4. No need
@jasonz-dfinity jasonz-dfinity added this pull request to the merge queue Feb 10, 2026
Merged via the queue into master with commit a9bea10 Feb 10, 2026
39 checks passed
@jasonz-dfinity jasonz-dfinity deleted the jason/custom-proposal-criticality-fix branch February 10, 2026 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants