chore: extract configure_icos from system_test.bzl#8745
Merged
Conversation
nmattia
added
the
CI_ALL_BAZEL_TARGETS
nmattia
force-pushed
the
nm-configure-icos
branch
from
5045bd0 to
df32845
Compare
This extract the IC-OS specific configuration out of the `system_test` macro and into a new file. The configuration returns a few dicts containing the necessary environment updates. This means the `system_test` macro is now focused on providing the infrastructure for the tests and can ignore the actual configuration. Over time more configuration can be extracted (prometheus vm config, etc).
nmattia
force-pushed
the
nm-configure-icos
branch
from
df32845 to
b9058ba
Compare
frankdavid
approved these changes
Feb 9, 2026
nmattia
commented
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extract the IC-OS specific configuration out of the
system_testmacro and into a new file. The configuration returns a few dicts containing the necessary environment updates.This means the
system_testmacro is now focused on providing the infrastructure for the tests and can ignore the actual configuration. Over time more configuration can be extracted (prometheus vm config, etc).