Skip to content

test(node): SEV registration unit tests#8719

Merged
andrewbattat merged 4 commits intomasterfrom
andrew/sev-registration-testing
Feb 11, 2026
Merged

test(node): SEV registration unit tests#8719
andrewbattat merged 4 commits intomasterfrom
andrew/sev-registration-testing

Conversation

@andrewbattat
Copy link
Contributor

@andrewbattat andrewbattat commented Feb 6, 2026

NODE-1837

Tests the previously uncovered SEV attestation code path in do_add_node.rs

@andrewbattat andrewbattat self-assigned this Feb 6, 2026
@github-actions github-actions bot added the test label Feb 6, 2026
@andrewbattat andrewbattat marked this pull request as ready for review February 6, 2026 22:37
@andrewbattat andrewbattat requested a review from a team as a code owner February 6, 2026 22:37
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):

  1. Update unreleased_changelog.md (if there are behavior changes, even if they are
    non-breaking).

  2. Are there BREAKING changes?

  3. Is a data migration needed?

  4. Security review?

How to Satisfy This Automatic Review

  1. Go to the bottom of the pull request page.

  2. Look for where it says this bot is requesting changes.

  3. Click the three dots to the right.

  4. Select "Dismiss review".

  5. In the text entry box, respond to each of the numbered items in the previous
    section, declare one of the following:

  • Done.

  • $REASON_WHY_NO_NEED. E.g. for unreleased_changelog.md, "No
    canister behavior changes.", or for item 2, "Existing APIs
    behave as before.".

Brief Guide to "Externally Visible" Changes

"Externally visible behavior change" is very often due to some NEW canister API.

Changes to EXISTING APIs are more likely to be "breaking".

If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.

If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.

Reference(s)

For a more comprehensive checklist, see here.

GOVERNANCE_CHECKLIST_REMINDER_DEDUP

@andrewbattat andrewbattat marked this pull request as draft February 7, 2026 00:07
@andrewbattat andrewbattat marked this pull request as ready for review February 7, 2026 00:09
@andrewbattat andrewbattat added this pull request to the merge queue Feb 11, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 11, 2026
@andrewbattat andrewbattat added this pull request to the merge queue Feb 11, 2026
github-merge-queue bot pushed a commit that referenced this pull request Feb 11, 2026
NODE-1837

Tests the previously uncovered SEV attestation code path in
`do_add_node.rs`
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 11, 2026
@andrewbattat andrewbattat added this pull request to the merge queue Feb 11, 2026
Merged via the queue into master with commit 9b02d5e Feb 11, 2026
67 of 68 checks passed
@andrewbattat andrewbattat deleted the andrew/sev-registration-testing branch February 11, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants