Fix edge case with rendering children as number 0#18
Open
dburles wants to merge 3 commits intodevelopit:masterfrom
Open
Fix edge case with rendering children as number 0#18dburles wants to merge 3 commits intodevelopit:masterfrom
dburles wants to merge 3 commits intodevelopit:masterfrom
Conversation
developit
reviewed
May 23, 2019
| while (stack.length) { | ||
| let child = stack.pop(); | ||
| if (child) { | ||
| if (child !== undefined && child !== null) { |
Owner
There was a problem hiding this comment.
This would allow <div>{true}</div> to render <div>true</div>. Do we want that? The VDOM libs ignore booleans.
In any case, this statement can compress to:
Suggested change
| if (child !== undefined && child !== null) { | |
| if (child != null) { |
Author
There was a problem hiding this comment.
It also allowed it before so we could leave as is or correct it, up to you. The shorter version while shorter is not explicit, it's better to always use the === and !== operators. Just my thoughts.
There was a problem hiding this comment.
I would concur with @dburles that being more explicit is often clearer. Also on the <div>{true}</div> debate mimicking the behaviour of React/Preact etc. seems intuitive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing in number 0 as a child would result in nothing being rendered. See test:
https://github.com/dburles/vhtml/blob/88278a1fb47f93edb40e974ab4eaf6923169f4a4/test/vhtml.js#L169-L178