Fix "nodenext" module resolution compatibility#214
Open
helgee wants to merge 1 commit intodevelopit:mainfrom
Open
Fix "nodenext" module resolution compatibility#214helgee wants to merge 1 commit intodevelopit:mainfrom
helgee wants to merge 1 commit intodevelopit:mainfrom
Conversation
|
can confirm this fixes the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to an item)
What changes did you make? (Give an overview)
Updated the
typeandexportsfields ofpackage.jsonto make the package compatible with"moduleResolution":"nodenext".Without these changes Typescript cannot resolve the default export with the above setting without workarounds.
Encountered during: threlte/threlte#1648
Is there anything you'd like reviewers to focus on?
No
Does this PR introduce a breaking change? (What changes might other developers need to make in their application due to this PR?)
No