Always cache apt metadata and downloads outside the image#989
Open
DavidS-ovm wants to merge 1 commit intodevcontainers:mainfrom
Open
Always cache apt metadata and downloads outside the image#989DavidS-ovm wants to merge 1 commit intodevcontainers:mainfrom
DavidS-ovm wants to merge 1 commit intodevcontainers:mainfrom
Conversation
This change uses cache mounts in the generated Dockerfiles for features to ensure that apt metadata and downloaded packages remain available throughout the build process without ever getting baked into layers. To make life easier for feature implementations, this also runs `apt update` once before the feature build, so that the metadata cache is up-to-date. This has the following benefits: * reduced build-time costs: apt metadata is only downloaded once * smaller layer size: features cannot accidentally include downloaded packages in their layer (see devcontainers/features#1298) * reduced complexity: features do not have to worry about apt caching and cache cleaning * optionally, if building on a caching buildkit service like depot.dev, the cache is re-used across builds, further reducing build-time
Author
|
@microsoft-github-policy-service agree company="Overmind Tech, Inc." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change uses cache mounts in the generated Dockerfiles for features to ensure that apt metadata and downloaded packages remain available throughout the build process without ever getting baked into layers. To make life easier for feature implementations, this also runs
apt updateonce before the feature build, so that the metadata cache is up-to-date.This has the following benefits:
apt cleanto reduce layer size features#1298)