-
Notifications
You must be signed in to change notification settings - Fork 157
refactor: reorganize directory structure #946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| # Format modules for dpdata | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,11 +5,11 @@ | |
|
|
||
| import numpy as np | ||
|
|
||
| from dpdata.amber.mask import pick_by_amber_mask | ||
| from dpdata.formats.amber.mask import pick_by_amber_mask | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: cat -n dpdata/formats/amber/md.py | head -20Repository: deepmodeling/dpdata Length of output: 598 🏁 Script executed: ruff check dpdata/formats/amber/md.pyRepository: deepmodeling/dpdata Length of output: 1706 Fix ruff linting violations before merge. The file has 3 ruff violations:
Run 🤖 Prompt for AI Agents |
||
| from dpdata.unit import EnergyConversion | ||
| from dpdata.utils import open_file | ||
|
|
||
| from ..periodic_table import ELEMENTS | ||
| from ...periodic_table import ELEMENTS | ||
|
|
||
| kcalmol2eV = EnergyConversion("kcal_mol", "eV").value() | ||
| symbols = ["X"] + ELEMENTS | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: deepmodeling/dpdata
Length of output: 2279
Package initializer structure is correct; however, ruff linting shows 386 errors across dpdata/ that must be resolved before merge.
The file itself is fine, but the broader directory has significant lint violations:
Formatting is compliant (107 files already formatted). Address the lint errors with
ruff check --fix dpdata/before merge to comply with the coding guidelines fordpdata/**/*.py.🤖 Prompt for AI Agents