Improvement of memory management for #678#699
Open
victor-cr wants to merge 2 commits intodebug-js:masterfrom
Open
Improvement of memory management for #678#699victor-cr wants to merge 2 commits intodebug-js:masterfrom
victor-cr wants to merge 2 commits intodebug-js:masterfrom
Conversation
…reated. Fix memory leak for a fixed number of categories. For dynamic categories method destroy is still required. debug-js#678
|
Thanks for this PR! I was thinking of submitting a similar one myself, as we just discovered that this memory leak was hitting us hard. I was thinking about using a Map instead of an object for the instances. Would that be a better choice? Map seems like the more suitable data structure for this usage and would simplify the code in |
Author
|
I have no objection of using |
This was referenced May 12, 2022
This was referenced May 6, 2022
This was referenced May 16, 2022
This was referenced Mar 7, 2023
This was referenced Mar 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoiding recreating logger for the namespace which has been already created. Fix memory leak for a fixed number of categories. For dynamic categories method destroy is still required. #678