Skip to content

Conversation

@javier-aliaga
Copy link
Contributor

@javier-aliaga javier-aliaga commented Feb 12, 2026

Description

The test is checking for the difference in seconds, so when the minute is different the substraction is not working as expected and the test fails

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Javier Aliaga <javier@diagrid.io>
@javier-aliaga javier-aliaga marked this pull request as ready for review February 12, 2026 16:04
@javier-aliaga javier-aliaga requested review from a team as code owners February 12, 2026 16:04
Signed-off-by: Javier Aliaga <javier@diagrid.io>
Signed-off-by: Javier Aliaga <javier@diagrid.io>
Signed-off-by: Javier Aliaga <javier@diagrid.io>
Signed-off-by: Javier Aliaga <javier@diagrid.io>
@javier-aliaga javier-aliaga changed the title chore: Fix waitForLoopEvent test chore: Fix Durable tasks flaky tests Feb 12, 2026
@javier-aliaga
Copy link
Contributor Author

@dapr/maintainers-java-sdk 🙏

Copy link
Contributor

@siri-varma siri-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find. LGTM. Thank you Javier.

@siri-varma siri-varma merged commit f283e3a into dapr:master Feb 13, 2026
17 of 22 checks passed
@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.21%. Comparing base (f660eb8) to head (a9515a5).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1653   +/-   ##
=========================================
  Coverage     79.21%   79.21%           
  Complexity     2141     2141           
=========================================
  Files           234      234           
  Lines          6456     6456           
  Branches        700      700           
=========================================
  Hits           5114     5114           
  Misses          990      990           
  Partials        352      352           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants