cleaned up simplecpp::Macro construction and assignment#596
Draft
firewave wants to merge 6 commits intodanmar:masterfrom
Draft
cleaned up simplecpp::Macro construction and assignment#596firewave wants to merge 6 commits intodanmar:masterfrom
simplecpp::Macro construction and assignment#596firewave wants to merge 6 commits intodanmar:masterfrom
Conversation
firewave
changed the title
simplecpp::Macro construction and assignmentsimplecpp::Macro construction and assignment
firewave
force-pushed
the
macro-emplace
branch
3 times, most recently
from
a431e1f to
e3792a3
Compare
| sizeOfType.insert(std::make_pair("float *", sizeof(float *))); | ||
| sizeOfType.insert(std::make_pair("double *", sizeof(double *))); | ||
| sizeOfType.insert(std::make_pair("long double *", sizeof(long double *))); | ||
| sizeOfType.emplace("char", sizeof(char)); |
Contributor
There was a problem hiding this comment.
This block could be an init list, followed by sizeOfType.insert(rawtokens.sizeOfType.begin(), rawtokens.sizeOfType.end()).
Collaborator
Author
There was a problem hiding this comment.
This is not even macro code. I will pull this out in a separate PR and apply you suggestion.
firewave
force-pushed
the
macro-emplace
branch
from
e3792a3 to
9af5e3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.