Enhance upload/download operation error messages#1793
Open
yarikoptic-gitmate wants to merge 4 commits intomasterfrom
Open
Enhance upload/download operation error messages#1793yarikoptic-gitmate wants to merge 4 commits intomasterfrom
yarikoptic-gitmate wants to merge 4 commits intomasterfrom
Conversation
Improve error messages in upload.py and download.py to provide clearer guidance: - Add file path context to "File not found" errors - Reference 'dandi validate' command for validation failures - Suggest checking file format and corruption for digest errors - Explain NWB specification requirements for metadata extraction - Provide example usage for download command when no URLs given These improvements help users quickly diagnose and fix upload/download issues. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1793 +/- ##
=======================================
Coverage 75.11% 75.12%
=======================================
Files 84 84
Lines 11922 11922
=======================================
+ Hits 8955 8956 +1
+ Misses 2967 2966 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yarikoptic
requested changes
Feb 13, 2026
Comment on lines
+111
to
+115
| raise NotImplementedError( | ||
| "No URLs were provided. Cannot download anything. " | ||
| "Provide a DANDI URL (e.g., 'dandi download DANDI:000027') " | ||
| "or use '--download' with a dandiset URL." | ||
| ) |
Contributor
There was a problem hiding this comment.
Not to be changed here per se, but wanted to point out this lovely linting check I ran into a while back and have gotten into the matter of using on all my projects
CodyCBakerPhD
approved these changes
Feb 13, 2026
Contributor
|
No code changes. Only text. Latest text reads well and adds more detail |
Contributor
|
@yarikoptic Unable to merge b/c your previous review was blocking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves upload and download error messages with diagnostic hints for quick issue resolution.
Changes
dandi validatecommand for detailsExample Improvements
Before:
After:
Benefits
Files Changed
dandi/upload.pydandi/download.pyTesting
Verified with full test suite: 548 passed, 0 failed.
Note: This PR may have minor conflicts with # if that hasn't merged yet. Both add docstrings and improve errors in upload.py/download.py but in different parts of the files.
See commit: 64a04262
Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com