Skip to content

fix(webapp): use rounded-14 styling for feedback badges#5671

Merged
rebelchris merged 2 commits intomainfrom
eng-987-update-buttons-to-use-rounded-14-styling
Mar 6, 2026
Merged

fix(webapp): use rounded-14 styling for feedback badges#5671
rebelchris merged 2 commits intomainfrom
eng-987-update-buttons-to-use-rounded-14-styling

Conversation

@rebelchris
Copy link
Contributor

@rebelchris rebelchris commented Mar 6, 2026

Summary

  • update feedback history badge pills on /settings/feedback from rounded-full to rounded-14
  • keep scope limited to the two badge spans in packages/webapp/pages/settings/feedback.tsx
  • simplify class usage by extracting a shared badgeClassName to avoid duplicated Tailwind classes

Verification

  • pnpm --filter webapp exec eslint pages/settings/feedback.tsx
  • NEXT_PUBLIC_API_URL=https://api.daily.dev pnpm --filter webapp build

Key Decisions

  • reused existing rounded-14 design token from shared Tailwind config instead of introducing new styling tokens
  • kept all other page elements unchanged to match requested scope

Closes ENG-987


Created by Huginn 🐦‍⬛

Preview domain

https://eng-987-update-buttons-to-use-ro.preview.app.daily.dev

@vercel
Copy link

vercel bot commented Mar 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
daily-webapp Ready Ready Preview Mar 6, 2026 1:30pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
storybook Ignored Ignored Mar 6, 2026 1:30pm

Request Review

@rebelchris rebelchris merged commit 864dc41 into main Mar 6, 2026
11 checks passed
@rebelchris rebelchris deleted the eng-987-update-buttons-to-use-rounded-14-styling branch March 6, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant