Skip to content

refactor: remove type: ignore by fixing build_embedder typing#4497

Open
supraja777 wants to merge 2 commits intocrewAIInc:mainfrom
supraja777:refactor/remove-type-ignore-typing
Open

refactor: remove type: ignore by fixing build_embedder typing#4497
supraja777 wants to merge 2 commits intocrewAIInc:mainfrom
supraja777:refactor/remove-type-ignore-typing

Conversation

@supraja777
Copy link

@supraja777 supraja777 commented Feb 16, 2026

Note

Low Risk
Low risk: mostly developer-tooling cleanup and small validation/typing adjustments; only minor behavioral change is more permissive handling of non-JSON config strings.

Overview
Simplifies local pre-commit hooks by removing the venv bash -c 'source ...' wrappers and running ruff, ruff format, and mypy directly via uv run.

In Crew, updates config validation to attempt json.loads for string inputs but fall back to returning the original string when it isn’t valid JSON (instead of assuming Json), and adjusts typing around embedder initialization by casting self.embedder when calling build_embedder plus a small signature formatting cleanup for _add_memory_tools.

Written by Cursor Bugbot for commit 22d588b. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments