Remove forward declarations to cgo exported funcs#146
Open
iamcalledrob wants to merge 3 commits intocrawshaw:masterfrom
Open
Remove forward declarations to cgo exported funcs#146iamcalledrob wants to merge 3 commits intocrawshaw:masterfrom
iamcalledrob wants to merge 3 commits intocrawshaw:masterfrom
Conversation
Contributor
|
Feel free to submit over at https://github.com/go-llsqlite/crawshaw if you get no traction. |
Author
|
@anacrolix I submitted a PR in that repo already! go-llsqlite/crawshaw#5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current source fails to build with clang on windows due to forward declarations.
It appears that cgo code within a go file shouldn't contain a forward declaration to a cgo exported function from within the same file.
This manifests as either a warning or an error on clang+windows due to dllexport. There is an open task on the golang repo to better document this: golang/go#49721
Here's what happens if you try and build this package using clang (or zig cc) on windows.
This PR:
CGO_LDFLAGSenv var for the windows linkerShould fix the root issue in #137