Update Settings page, use system name and language code; add a11y Copilot instructions.#18521
Open
gcamacho079 wants to merge 9 commits into6.xfrom
Open
Update Settings page, use system name and language code; add a11y Copilot instructions.#18521gcamacho079 wants to merge 9 commits into6.xfrom
gcamacho079 wants to merge 9 commits into6.xfrom
Conversation
gcamacho079
changed the title
There was a problem hiding this comment.
Pull request overview
This PR updates the Control Panel’s Settings UX and global page metadata to improve accessibility and context, and adds repository Copilot guidance for building accessible UI.
Changes:
- Append the system name to the document title via
AppLayout. - Add the current language code to the root HTML
<html lang="...">and expose it in shared Inertia “craft” props. - Make Settings links unique for screen readers by adding a visually-hidden “ - Settings” suffix.
- Add
.githubaccessibility coding instructions for Copilot.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/Http/Middleware/HandleInertiaRequests.php |
Shares locale into view + adds craft.app.language Inertia prop. |
resources/views/app.blade.php |
Sets <html lang> from a shared $language variable. |
resources/js/pages/SettingsIndexPage.vue |
Adds visually-hidden “ - Settings” suffix to link text. |
resources/js/layout/AppLayout.vue |
Computes and sets a full document title including system name. |
.github/instructions/a11y.instructions.md |
Adds accessibility-focused Copilot instructions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Criteria
currentUser) should include the language code on thehtmlelementRelated issues
Resolves ACC-34