🐛 Fix printing variables when expect or assert fails#103
Open
dustingooding wants to merge 1 commit intocpp-testing:masterfrom
Open
🐛 Fix printing variables when expect or assert fails#103dustingooding wants to merge 1 commit intocpp-testing:masterfrom
dustingooding wants to merge 1 commit intocpp-testing:masterfrom
Conversation
Problem: - EXPECT and ASSERT macros only print whether the expression is true or false when the test expectations fail - GUnit stopped printing out the values of the variables used in the expressiong passed to the EXPECT or ASSERT macros - Fix for logical expression broke variable printing Solution: - Remove extra parenthesis in macros that resulted in full evaluation of the expression before the op and cmp objects could be initialized. - Add CmpHelperAnd/Or/Xor with corresponding and/or/xor overloads to allow evaluating logical expressions. - Added test to verify tested expressions are only evaluated once.
Contributor
|
thanks @dustingooding, LGTM, just a small complain from the compiler about C++20, otherwise happy to get that in. |
Contributor
Author
|
Actually, I don't think these errors are because of my changes. It looks like the MacOS and Windows failures started with #102? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Solution: